[CI] Fix detecting usage of private emails #19394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
force-pushed
the
private/udit/email_test
branch
from
5bb431a to
178d1e6
Compare
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
|
uditagarwal97
force-pushed
the
private/udit/email_test
branch
from
1c31737 to
93b0594
Compare
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
PS:- the "private email" workflow is failing in the precommit because I've made my email hidden in the GH profile. To demonstrate the changes made in this PR> |
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Jul 10, 2025
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
… Github UI (#148694) **Problem** Currently, the email check workflow uses `git` to see email used for the last commit but the email address used when merging is actually governed by GitHub settings not what's stored in `git`. Due to this, the email check workflow passes even when the author's email is private in Github. We saw several such cases in our fork of llvm. See #17675 **Solution** Try to find user's email using GH's GraphQL APIs. User's email will be null if it's hidden in the profile. --------- Signed-off-by: Agarwal, Udit <[email protected]>
uditagarwal97
force-pushed
the
private/udit/email_test
branch
from
93b0594 to
df8156a
Compare
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
reviewed
Jul 16, 2025
| @@ -39,6 +55,9 @@ jobs: | |||
| [{"body" : "$COMMENT"}] | |||
| EOF | |||
|
|
|||
| # Fail this job. | |||
| false | |||
There was a problem hiding this comment.
did we have this part upstream? or they didnt want it?
There was a problem hiding this comment.
No, it's not a part of upstream as of now. But, as per llvm/llvm-project#148694 (comment), I'll be making a separate PR to make the workflow fail in the upstream.
|
@sarnex I've re-worked the fix based on the feedback I got from the community. The fix in this PR now cherry-picks llvm/llvm-project#148694 and makes the workflow fail when private email is used. I'm working on a separate PR to make the workflow fail in upstream (based on llvm/llvm-project#148694 (comment)), but I suppose that will take some time, so in the meanwhile we can have the fix in intel/llvm atleast. |
sarnex
approved these changes
Jul 16, 2025
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
added a commit
that referenced
this pull request
Jul 16, 2025
This reverts commit efe5a5b.
uditagarwal97
added a commit
that referenced
this pull request
Jul 16, 2025
Reverts #19394 sadly. The workflow is failing if user's email is not listed publicly on your GH profile. This is different from not having your email public on Github (in Github email settings page vs. email field in Github profile/email settings). Reverting this PR till I figure out a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17675
Currently, in the workflow, we only check the email that was used for the latest commit in the PR. This email can differ from the email settings on the GH UI, from which PR will be authored, once we merge it.